app: Drop static buffers from SMS module#221
Closed
SeppoTakalo wants to merge 1 commit into
Closed
Conversation
Drop statically defined buffers from SMS module. Use urc_send_to() for sending a complete messages directly to formatting buffer in AT host, instead of formatting into internal buffers. For concatenated messages, use strdup() to allocate temporary memory. When all messages are received, print directly to buffer in AT host using urc_send_to(). Clean up buffers in work handler after 5 minutes, if something was still pending, or without a delay, if OK. Signed-off-by: Seppo Takalo <seppo.takalo@nordicsemi.no>
Collaborator
|
I've accommodated a lot of these changes into PR #203. I think this PR could be closed. |
Collaborator
|
I'll close this since PR #203 will handle relevant parts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop statically defined buffers from SMS module.
Use urc_send_to() for sending a complete messages
directly to formatting buffer in AT host, instead
of formatting into internal buffers.
For concatenated messages, use strdup() to allocate temporary memory.
When all messages are received, print directly to
buffer in AT host using urc_send_to().
Clean up buffers in work handler after 5 minutes,
if something was still pending, or without a delay, if OK.