Skip to content

app: Drop static buffers from SMS module#221

Closed
SeppoTakalo wants to merge 1 commit into
nrfconnect:mainfrom
SeppoTakalo:sms_strdup
Closed

app: Drop static buffers from SMS module#221
SeppoTakalo wants to merge 1 commit into
nrfconnect:mainfrom
SeppoTakalo:sms_strdup

Conversation

@SeppoTakalo
Copy link
Copy Markdown
Contributor

Drop statically defined buffers from SMS module.

Use urc_send_to() for sending a complete messages
directly to formatting buffer in AT host, instead
of formatting into internal buffers.

For concatenated messages, use strdup() to allocate temporary memory.
When all messages are received, print directly to
buffer in AT host using urc_send_to().

Clean up buffers in work handler after 5 minutes,
if something was still pending, or without a delay, if OK.

Drop statically defined buffers from SMS module.

Use urc_send_to() for sending a complete messages
directly to formatting buffer in AT host, instead
of formatting into internal buffers.

For concatenated messages, use strdup() to allocate
temporary memory.
When all messages are received, print directly to
buffer in AT host using urc_send_to().

Clean up buffers in work handler after 5 minutes,
if something was still pending, or without a delay, if OK.

Signed-off-by: Seppo Takalo <seppo.takalo@nordicsemi.no>
@trantanen
Copy link
Copy Markdown
Collaborator

I've accommodated a lot of these changes into PR #203. I think this PR could be closed.

@trantanen
Copy link
Copy Markdown
Collaborator

I'll close this since PR #203 will handle relevant parts.

@trantanen trantanen closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants